linux-kernel - Re: [PATCH 1/5] pci/of: Match PCI devices to OF nodes dynamically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110407.153121.115952367.davem@davemloft.net>
Date:	Thu, 07 Apr 2011 15:31:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	benh@...nel.crashing.org
Cc:	linux-pci@...r.kernel.org, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org, bheglaas@...gle.com,
	monstr@...str.eu, tglx@...uxtronix.de, bigeasy@...uxtronix.de
Subject: Re: [PATCH 1/5] pci/of: Match PCI devices to OF nodes dynamically

From: David Miller <davem@...emloft.net>
Date: Thu, 07 Apr 2011 15:29:37 -0700 (PDT)

> From: David Miller <davem@...emloft.net>
> Date: Thu, 07 Apr 2011 15:27:07 -0700 (PDT)
> 
>> However, of_pci_find_child_device() lives in drivers/of/of_pci.c which is not
>> built into the tree because you haven't provided the necessary changes to
>> drivers/of/Makefile in this patch.
> 
> Oh I see, it exists already but it's only built into the tree for
> microblaze, x86, and ppc.
> 
> There's a lot of stuff in there which is superfluous and will never
> be used on sparc.
> 
> Everything in there except the new of_pci_find_child_device() function
> will be never ever used on sparc and therefore dead code.

Furthermore it will never build on sparc even if we wanted to do so
temporarily because it references interfaces sparc doesn't provide:

drivers/of/of_pci.c: In function ‘of_irq_map_pci’:
drivers/of/of_pci.c:32:3: error: implicit declaration of function ‘of_irq_map_one’ [-Werror=implicit-function-declaration]
drivers/of/of_pci.c:56:4: error: implicit declaration of function ‘pci_bus_to_OF_node’ [-Werror=implicit-function-declaration]
drivers/of/of_pci.c:56:11: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/of/of_pci.c:90:2: error: implicit declaration of function ‘of_irq_map_raw’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

I don't think it's a good idea to mix the things you're trying to do
with all of the existing stuff in of_pci.c, why not create a new file
for the stuff you're trying to consolidate?