linux-kernel - Re: [PATCH v3] ARM: Use generic BUG() handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D9D4D23.6000805@codeaurora.org>
Date:	Wed, 06 Apr 2011 22:35:31 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Simon Glass <sjg@...omium.org>
CC:	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Joe Perches <joe@...ches.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Alexander Shishkin <virtuoso@...nd.org>,
	Phil Carmody <ext-phil.2.carmody@...ia.com>,
	Rabin Vincent <rabin@....in>, linux-kernel@...r.kernel.org,
	Omar Ramirez Luna <omar.ramirez@...com>,
	Dave Martin <dave.martin@...aro.org>,
	Simon Glass <sjg@...gle.com>
Subject: Re: [PATCH v3] ARM: Use generic BUG() handler

On 4/6/2011 4:18 PM, Simon Glass wrote:
> v3: Remove old BUG() implementation in favor of this one.
> Remove the Backtrace: message (will submit this separately).
> Use ARM_EXIT_KEEP() so that some architectures can dump exit text at link time
> thanks to Stephen Boyd <sboyd@...eaurora.org> (although since we always
> define GENERIC_BUG this might be academic.)

Its not entirely academic because CONFIG_BUG=n and CONFIG_SMP_ON_UP=n
would allow us to remove the exit text. This could be huge for people
who want to cram kernel's onto space constrained devices.

> Rebase to linux-2.6.git master.
>
> Change-Id: I07d77c832e816f5ad2390e25f466ddf750adecf4

Don't forget to remove these before submitting to the patch tracker (and
sending to the list).

> diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h
> index 4d88425..2914724 100644
> --- a/arch/arm/include/asm/bug.h
> +++ b/arch/arm/include/asm/bug.h
> @@ -3,21 +3,58 @@
>  
>  
>  #ifdef CONFIG_BUG
> -#ifdef CONFIG_DEBUG_BUGVERBOSE
> -extern void __bug(const char *file, int line) __attribute__((noreturn));
> -
> -/* give file/line information */
> -#define BUG()		__bug(__FILE__, __LINE__)

Does anybody reference __bug() anymore? If not you can remove that too.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/