linux-kernel - Re: [PATCH] selinux: downgrade two printks to KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1302267622.3937.3.camel@localhost.localdomain>
Date:	Fri, 08 Apr 2011 09:00:20 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Stephen Smalley <sds@...ho.nsa.gov>,
	James Morris <jmorris@...ei.org>,
	Eric Paris <eparis@...isplace.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selinux: downgrade two printks to KERN_DEBUG

They shouldn't be there at all and it was a big screw up on my part that
they were left in the committed code.  I already applied but haven't
sent or pushed a patch to remove these.  Thanks Paul!

-Eric

On Fri, 2011-04-08 at 11:03 +0200, Paul Bolle wrote:
> A recent (Fedora Rawhide) selinux policy update triggers this error:
>     filename_trans_read: nel=0
> 
> But there seems to be no reason why filename_trans_read() prints this
> message (and a similar message) at KERN_ERR level. So downgrade it to
> KERN_DEBUG level.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> Compile tested only.
> 
>  security/selinux/ss/policydb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
> index e7b850a..8e9cc8d10 100644
> --- a/security/selinux/ss/policydb.c
> +++ b/security/selinux/ss/policydb.c
> @@ -1819,7 +1819,7 @@ static int filename_trans_read(struct policydb *p, void *fp)
>  		goto out;
>  	nel = le32_to_cpu(buf[0]);
>  
> -	printk(KERN_ERR "%s: nel=%d\n", __func__, nel);
> +	printk(KERN_DEBUG "%s: nel=%d\n", __func__, nel);
>  
>  	last = p->filename_trans;
>  	while (last && last->next)
> @@ -1857,7 +1857,7 @@ static int filename_trans_read(struct policydb *p, void *fp)
>  			goto out;
>  		name[len] = 0;
>  
> -		printk(KERN_ERR "%s: ft=%p ft->name=%p ft->name=%s\n", __func__, ft, ft->name, ft->name);
> +		printk(KERN_DEBUG "%s: ft=%p ft->name=%p ft->name=%s\n", __func__, ft, ft->name, ft->name);
>  
>  		rc = next_entry(buf, fp, sizeof(u32) * 4);
>  		if (rc)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/