linux-kernel - Re: [PATCHv2 6/7] basic_mmio_gpio: support different input/output registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110408144051.GF2933@pulham.picochip.com>
Date:	Fri, 8 Apr 2011 15:40:51 +0100
From:	Jamie Iles <jamie@...ieiles.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Jamie Iles <jamie@...ieiles.com>, linux-kernel@...r.kernel.org,
	linux@....linux.org.uk, tglx@...utronix.de,
	grant.likely@...retlab.ca, arnd@...db.de, nico@...xnic.net
Subject: Re: [PATCHv2 6/7] basic_mmio_gpio: support different input/output
 registers

On Fri, Apr 08, 2011 at 06:36:41PM +0400, Anton Vorontsov wrote:
> On Fri, Apr 08, 2011 at 03:16:50PM +0100, Jamie Iles wrote:
> [...]
> > +	res_in = platform_get_resource_byname(pdev, IORESOURCE_MEM, "in");
> > +	if (res_in) {
> > +		bgc->reg_in = bgpio_request_and_map(&pdev->dev, res_in);
> > +		if (!bgc->reg_in)
> > +			return -ENOMEM;
> > +		bgc->gc.get = bgpio_get_in;
> > +	} else {
> > +		bgc->gc.get = bgpio_get_dat;
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> >  	return 0;
> >  }
> 
> Hm.. will this compile?

No, I accidentally squashed patches 6 and 7 together then obviously 
didn't split them properly.  I'll fix this (and the spacing around the 
locking and repost).

Sorry!

Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/