linux-kernel - Re: [PATCH] Allow O_SYNC to be set by fcntl(F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110408151454.GA1444@infradead.org>
Date:	Fri, 8 Apr 2011 11:14:55 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Steve Rago <sar@...-labs.com>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] Allow O_SYNC to be set by fcntl(F_SETFL)

I actually prototypes this patch independetly a while ago, and in
addition to the data writeout when removing O_SYNC there are the
following caveats:

 - O_SYNC is not actually one flag, but two: O_DSYNC and __O_SYNC.
   setfl() needs to make sure __O_SYNC cannot be in f_flags without
   O_DSYNC also beeing present.
 - we need to audit all filesystems that they don't do stupid things
   when the O_SYNC flags appear or disappear during a write, that
   is make sure it is checked in just one place.  The generic write
   code is fine in that respect, but I didn't go through all filesystems
   to verify it yet.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/