[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <10e5cbf67c850b6ae511979bdbad1761236ad9b0.1302247435.git.michael@ellerman.id.au>
Date: Fri, 8 Apr 2011 17:24:01 +1000 (EST)
From: Michael Ellerman <michael@...erman.id.au>
To: <linux-kernel@...r.kernel.org>
Cc: <linux-mm@...ck.org>, <hughd@...gle.com>, <walken@...gle.com>,
<aarcange@...hat.com>, <riel@...hat.com>,
Andrew Morton <akpm@...l.org>, <linuxppc-dev@...abs.org>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: [PATCH] mm: Check we have the right vma in __access_remote_vm()
In __access_remote_vm() we need to check that we have found the right
vma, not the following vma, before we try to access it. Otherwise we
might call the vma's access routine with an address which does not
fall inside the vma.
Signed-off-by: Michael Ellerman <michael@...erman.id.au>
---
mm/memory.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 9da8cab..ce999ca 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3678,7 +3678,7 @@ static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm,
*/
#ifdef CONFIG_HAVE_IOREMAP_PROT
vma = find_vma(mm, addr);
- if (!vma)
+ if (!vma || vma->vm_start > addr)
break;
if (vma->vm_ops && vma->vm_ops->access)
ret = vma->vm_ops->access(vma, addr, buf,
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists