linux-kernel - Re: [PATCH] ux500: Adding support for u8500 Hsem functionality.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BANLkTikMy7vpz8z479sCuROgjV8EK03FUQ@mail.gmail.com>
Date:	Sat, 9 Apr 2011 10:53:48 +0300
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	mathieu.poirier@...aro.org
Cc:	linux-arm-kernel@...ts.infradead.org, lee.jones@...aro.org,
	patches@...aro.org, linus.walleij@...ricsson.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ux500: Adding support for u8500 Hsem functionality.

Hi Mathieu,

On Fri, Apr 8, 2011 at 11:28 PM,  <mathieu.poirier@...aro.org> wrote:
...

> + * Author: Mathieu Poirier <mathieu.poirier@...aro.org>
> + * Heavily borrowed from the work of :
> + *   Simon Que <sque@...com>
> + *   Hddari Kanigeri <h-kanigeri2@...com>

s/Hddari/Hari/

> +       platform_set_drvdata(pdev, state);
> +
> +       /* no pm needed for HSem but required to comply
> +        * with hwspilock core.
> +        */
> +       pm_runtime_enable(&pdev->dev);

You seem to have removed the calls to pm_runtime_disable() throughout
the driver, is that on purpose ?

You should see an "Unbalanced pm_runtime_enable!" warning about this
if you tried rmmod'ing and insmod'ing the driver again.

And just a minor comment if you're submitting a v2: you have a bunch
of trailing whitespaces; try checkpatch to spot them easily.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/