linux-kernel - Re: [PATCH] perf: Don't schedule tracepoints when exclude

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110409131702.GA14331@elte.hu>
Date:	Sat, 9 Apr 2011 15:17:02 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf: Don't schedule tracepoints when exclude_kernel is
 set


* Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:

> On Fri, 2011-04-08 at 22:57 +0200, Frederic Weisbecker wrote:
> > Instead of checking attr.exclude_kernel anytime a tracepoint
> > event triggers, simply don't schedule the tracepoint it that
> > attribute is set. This makes one test less in the tracing
> > path.
> 
> Meh, I'd much rather someone spend some time on finishing the below,
> which is a much bigger improvement for trace-events.
> 
> ---
> Subject: perf: Tracepoint collection support
> From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Date: Sat Nov 20 18:09:34 CET 2010
> 
> Due to popular demand this implements a tracepoint collection event
> { .type = PERF_TYPE_TRACEPOINT, .config = ~0ULL }. by default it
> contains no tracepoints, but tracepoints can be added using:
>   ioctl(fd, PERF_EVENT_IOC_ADD_TP, tp_id);

+1 !!!

This is like a super-important feature.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/