linux-kernel - Re: [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1104081928160.6392@deuxcents.site>
Date:	Sun, 10 Apr 2011 08:05:42 -0700 (PDT)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Nikanth Karthikesan <knikanth@...e.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Anton Altaparmakov <aia21@....ac.uk>,
	linux-ntfs-dev@...ts.sourceforge.net,
	"Richard Russon (FlatCap)" <ldm@...tcap.org>,
	Klaus Hartmann <Klaus.Hartmann@...fujitsu.com>,
	Andries Brouwer <aeb@....nl>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Silence "ldm_validate_partition_table(): Disk read
 failed" when booting with "quiet"

On Thu, 17 Mar 2011, Nikanth Karthikesan wrote:

> From: Nikanth Karthikesan <knikanth@...e.de>
> Subject: Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"
> 
> When the kernel does partition detection, on certain configurations with
> external fibre channel raid systems (e.g. clariion from EMC) the read
> would fail. And "ldm_validate_partition_table(): Disk read failed"
> messages are printed to the console.
> 
> But the failure to read is not a critical error. Now since the message
> is flagged as KERN_CRIT, it gets printed even when booting with the
> "quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to
> read here is not really an error.
> 
> Signed-off-by: Nikanth Karthikesan <knikanth@...e.de>
> Reported-by : Klaus Hartmann <Klaus.Hartmann@...fujitsu.com>
> Signed-off-by: Anton Altaparmakov <aia21@...tab.net>
> 
> ---
> 
> diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c
> index b10e354..ea648b9 100644
> --- a/fs/partitions/ldm.c
> +++ b/fs/partitions/ldm.c
> @@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state)
>  
>  	data = read_part_sector(state, 0, &sect);
>  	if (!data) {
> -		ldm_crit ("Disk read failed.");
> +		ldm_info ("Disk read failed.");
>  		return false;
>  	}

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/