linux-kernel - Re: [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110411185807.GC2511@tuxdriver.com>
Date:	Mon, 11 Apr 2011 14:58:36 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	wwguy <wey-yi.w.guy@...el.com>
Cc:	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dave Airlie <airlied@...il.com>,
	Stanislaw Gruszka <sgruszka@...hat.com>
Subject: Re: [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY

On Mon, Apr 11, 2011 at 11:39:22AM -0700, wwguy wrote:
> On Mon, 2011-04-11 at 10:06 -0700, John W. Linville wrote:
> > Otherwise, IWLWIFI_LEGACY has to be selected independently before the
> > drivers are made available.
> > 
> > Reported-by: Dave Airlie <airlied@...il.com>
> > Signed-off-by: John W. Linville <linville@...driver.com>
> > Cc: Stanislaw Gruszka <sgruszka@...hat.com>
> > Cc: Wey-Yi Guy <wey-yi.w.guy@...el.com>
> > ---
> >  drivers/net/wireless/iwlegacy/Kconfig |    9 +++++----
> >  1 files changed, 5 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/iwlegacy/Kconfig b/drivers/net/wireless/iwlegacy/Kconfig
> > index 2a45dd4..aef65cd 100644
> > --- a/drivers/net/wireless/iwlegacy/Kconfig
> > +++ b/drivers/net/wireless/iwlegacy/Kconfig
> > @@ -1,6 +1,5 @@
> >  config IWLWIFI_LEGACY
> > -	tristate "Intel Wireless Wifi legacy devices"
> > -	depends on PCI && MAC80211
> > +	tristate
> >  	select FW_LOADER
> >  	select NEW_LEDS
> >  	select LEDS_CLASS
> 
> Should we add some ---help--- here?, or not..

Why would you need it?  This is now automatically selected by the
driver -- the user doesn't see it.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/