linux-kernel - Re: [PATCH] fsldma: fix build warning caused by of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110411063648.GB4439@angua.secretlab.ca>
Date:	Sun, 10 Apr 2011 23:36:48 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	"Ira W. Snyder" <iws@...o.caltech.edu>
Cc:	linux-kernel@...r.kernel.org,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] fsldma: fix build warning caused by of_platform_device
 changes

On Thu, Apr 07, 2011 at 10:33:03AM -0700, Ira W. Snyder wrote:
> Commit 000061245a6797d542854106463b6b20fbdcb12e forgot to convert the
> type of structure passed into platform_device_register() when it was
> converted from of_platform_device_register. Fix it.
> 
> Signed-off-by: Ira W. Snyder <iws@...o.caltech.edu>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Cc: Dan Williams <dan.j.williams@...el.com>

Applied thanks.

One comment however; when quoting sha1 commit id's, please also quote
the title of the patch.  Very few people I know can remember off the
top of their head the commit names that goes with a sha1 id.  :-)

g.

> ---
>  drivers/dma/fsldma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> index 6b39675..8a78154 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1448,7 +1448,7 @@ static const struct of_device_id fsldma_of_ids[] = {
>  	{}
>  };
>  
> -static struct of_platform_driver fsldma_of_driver = {
> +static struct platform_driver fsldma_of_driver = {
>  	.driver = {
>  		.name = "fsl-elo-dma",
>  		.owner = THIS_MODULE,
> -- 
> 1.7.3.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/