linux-kernel - [PATCH] drivers/spi/atmel_spi.c: prevent premature irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <EF2E73589CA71846A15D0B2CDF79505D086F931361@wm021.weinmann.com>
Date:	Mon, 11 Apr 2011 08:53:59 +0200
From:	"Voss, Nikolaus" <N.Voss@...nmann.de>
To:	"'Linux Kernel'" <linux-kernel@...r.kernel.org>
CC:	"'Nicolas Ferre'" <nicolas.ferre@...el.com>
Subject: [PATCH] drivers/spi/atmel_spi.c: prevent premature irqs

When restarting a kernel using kexec, filled rx buffers on SPI master
interface reliably crash the kernel. This patch disables rx interrupts
on startup to avoid this. Interrupts will be regulary enabled at start
of a new SPI master transfer.

Signed-off-by: Nikolaus Voss <n.voss@...nmann.de>
---
 drivers/spi/atmel_spi.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/spi/atmel_spi.c b/drivers/spi/atmel_spi.c
index 1a478bf..d17f14c 100644
--- a/drivers/spi/atmel_spi.c
+++ b/drivers/spi/atmel_spi.c
@@ -811,6 +811,9 @@ static int __init atmel_spi_probe(struct platform_device *pdev)
 	as->irq = irq;
 	as->clk = clk;
 
+	/* disable rx interrupts to avoid premature irq triggering */
+	spi_writel(as, IDR, SPI_BIT(RXBUFF) | SPI_BIT(ENDRX) | SPI_BIT(OVRES));
+
 	ret = request_irq(irq, atmel_spi_interrupt, 0,
 			dev_name(&pdev->dev), master);
 	if (ret)
-- 
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/