linux-kernel - Re: [PATCH 1/2] ux500: Adding support for u8500 Hsem functionality V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Apr 2011 16:44:29 +0300
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	mathieu.poirier@...aro.org
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	lee.jones@...aro.org, patches@...aro.org,
	linus.walleij@...ricsson.com
Subject: Re: [PATCH 1/2] ux500: Adding support for u8500 Hsem functionality V2

On Mon, Apr 11, 2011 at 6:24 PM, <mathieu.poirier@...aro.org> wrote:
>
> From: Mathieu J. Poirier <mathieu.poirier@...aro.org>
>
> This is the second spin on STE's Hsem driver that is implemented
> through the hwspinlock scheme.  More specifically:
>
>  More comments have been added in the code.
>  Cleanup of included header files.
>  One of the original contributor's name corrected.
>  Calls to 'pm_runtime_disable'restored.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> ---

Looks good, but please revise the commit log (think of a random reader
who tries to understand what does this patch do, and is less
interested to hear about its revisions' history).

Otherwise,

Acked-by: Ohad Ben-Cohen <ohad@...ery.com>

(btw I assume the "PATCH 1/2" in the subject is just a typo, and
there's no missing "PATCH 2/2")
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/