linux-kernel - Re: [PATCH v4 1/2] Use "request_muxed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTikFr+7duu71=yB2rVBKx1SBkmggqg@mail.gmail.com>
Date:	Tue, 12 Apr 2011 08:46:26 -0700
From:	Natarajan Gurumoorthy <natg@...gle.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Guenter Roeck <guenter.roeck@...csson.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Mike Waychison <mikew@...gle.com>, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v4 1/2] Use "request_muxed_region" in it87 watchdog drivers

Alan,
      I looked at your code in kernel/resource.c and I agree the while
is not needed. I guess every time it comes back from "schedule" your
code loops back to reserve the region. I will test the code without
the while and make the needed change.

Regards
Nat

On Tue, Apr 12, 2011 at 4:41 AM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
>> +     while (!request_muxed_region(REG, 2, NAME))
>> +             continue;
>> +
>
> This shouldn't need the loop ? - is it only working with the loop
> present ?
>
>
> Otherwise this looks good - I'd just like to understand if the loop was
> needed (indicating a bug has crept into the muxed alloc code somewhere
> perhaps) or not
>
> Alan
>



-- 
Regards
Nat Gurumoorthy AB6SJ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/