linux-kernel - Re: [PATCH 2/6] signal: retarget_shared_pending: consider shared/unblocked signals only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110412195321.GA15586@redhat.com>
Date:	Tue, 12 Apr 2011 21:53:21 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	Tejun Heo <tj@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Nikita V. Youshchenko" <nyoushchenko@...sta.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] signal: retarget_shared_pending: consider
	shared/unblocked signals only

On 04/12, Matt Fleming wrote:
>
> On Mon, 11 Apr 2011 19:20:45 +0200
> Oleg Nesterov <oleg@...hat.com> wrote:
>
> > exit_signals() checks signal_pending() before
> > retarget_shared_pending() but this is suboptimal. We can avoid the
> > while_each_thread() loop in case when there are no shared signals
> > visible to us.
> >
> > Add the has_pending_signals(shared_pending, blocked) check. We don
> > not use tsk->blocked directly but pass this sigset_t as an argument,
> > this is needed for the next patch.
> >
> > Note: we can optimize this more. while_each_thread(t) can check
> > t->blocked into account and stop after every pending signal has the
> > new target.
> >
> > Signed-off-by: Oleg Nesterov <oleg@...hat.com>
>
> Nice. Do you have plans to implement that further optimisation?

Probably yes, this is straightforward...

> Reviewed-by: Matt Fleming <matt.fleming@...ux.intel.com>

Thanks Matt, thanks all.

I'll reply to other emails tomorrow. I was distracted by other things,
sorry. Oh, as always :/

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/