linux-kernel - Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110413083855.c37ddadc.sfr@canb.auug.org.au>
Date:	Wed, 13 Apr 2011 08:38:55 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Jean Delvare <khali@...ux-fr.org>, Ben Dooks <ben-linux@...ff.org>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Baruch Siach <baruch@...s.co.il>, linux-i2c@...r.kernel.org,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI

Hi Jean, Ben,

On Tue, 12 Apr 2011 11:47:22 +0200 Jean Delvare <khali@...ux-fr.org> wrote:
>
> On Sat, 9 Apr 2011 13:34:49 +0200, Geert Uytterhoeven wrote:
> > On Fri, Apr 8, 2011 at 17:32, Randy Dunlap <randy.dunlap@...cle.com> wrote:
> > > From: Randy Dunlap <randy.dunlap@...cle.com>
> > >
> > > i2c-designware-pcidrv is a PCI driver and should depend on PCI.
> > > Fixes these build errors:
> > >
> > > drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region'
> > > drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region'
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> > > Cc: Baruch Siach <baruch@...s.co.il>
> > > ---
> > >  drivers/i2c/busses/Kconfig |    1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > Does anybody merge i2c patches???
> > 
> > Yes please, it's been there since Mar 17, reported several times, and probably
> > masking other build failures.
> 
> This bug only exists in linux-next, as the code in question wasn't
> merged in Linus's tree yet. It is drawn into linux-next from Ben
> Dooks's next-i2c branch:
>   http://git.fluff.org/gitweb?p=bjdooks/linux.git;a=shortlog;h=refs/heads/next-i2c
> 
> This is where it has to be fixed, so only Ben can do it. Ben, please?
> 
> Meanwhile, it should be possible to apply a hot fix to linux-next
> directly, Stephen does it pretty often. Stephen, could you please apply
> this fix temporarily until Ben wakes up and applies it to his tree?

I will apply this patch as a merge fixup from today (if it is still
needed).  I also have a patch being applied to that tree to add an
include of linux/delay.h to drivers/i2c/busses/i2c-designware-core.c .

Ben?
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped