linux-kernel - Re: [RFC-v3 2/3] qla2xxx: Enable 2xxx series LLD target mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1302593884.25449.68.camel@haakon2.linux-iscsi.org>
Date:	Tue, 12 Apr 2011 00:38:04 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Vladislav Bolkhovitin <vst@...b.net>
Cc:	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	Mike Christie <michaelc@...wisc.edu>,
	Madhu Iyengar <madhu.iyengar@...gic.com>,
	Andrew Vasquez <andrew.vasquez@...gic.com>,
	Ruediger Oertel <ro@...e.de>, Andy Grover <agrover@...hat.com>
Subject: Re: [RFC-v3 2/3] qla2xxx: Enable 2xxx series LLD target mode
	support

On Mon, 2011-04-11 at 22:37 +0400, Vladislav Bolkhovitin wrote:
> Nicholas A. Bellinger, on 04/05/2011 09:11 AM wrote:
> > From: Nicholas Bellinger <nab@...ux-iscsi.org>
> > 
> > This patch enables target mode support with the qla2xxx SCSI LLD using
> > qla_target.c logic introduced in commit f86d9fc734.  This includes:
> > 
> > *) Addition of target mode specific members to existing data
> > structures in qla_def.h and struct qla_hw_data->qla2x_tmpl using
> > qla_target.h:struct qla_target_template.
> > 
> > *) Addition of struct qla_target_template and direct calls into
> > qla_target.c logic w/ qla_tgt_* prefixed functions.
> > 
> > *) Addition of qla_iocb:qla2x00_req_pkt() for ring processing, and
> > qla2x00_issue_marker() for handling request/response queue processing
> > for target mode operation
> > 
> > *) Addition of various qla_tgt_mode_enabled() logic checks in
> > qla24xx_nvram_config(), qla2x00_initialize_adapter(), qla2x00_rff_id(),
> > qla2x00_abort_isp(), qla24xx_modify_vp_config(), and qla2x00_vp_abort_isp().
> > 
> > For the specific checks for qla_hw_data->qla2x_tmpl this includes:
> > 
> > *) control plane:
> > 
> > qla_init.c:qla2x00_rport_del() -> qla_tgt_fc_port_deleted()
> > qla_init.c:qla2x00_reg_remote_port() -> qla_tgt_fc_port_added()
> > qla_init.c:qla2x00_device_resync() -> qla2x00_mark_device_lost()
> > 
> > *) I/O path:
> > 
> > qla_isr.c:qla2x00_async_event() -> qla_tgt_async_event()
> > qla_isr.c:qla2x00_process_response_queue() -> qla_tgt_response_pkt_all_vps()
> > qla_isr.c:qla24xx_process_response_queue() -> qla_tgt_response_pkt_all_vps()
> 
> Most of this code was written by me and other SCST developers. How about
> to give proper credits to the original authors?
> 

Hello Vlad,

I intend to give proper fabric module credit where fabric module credit
is due  The original copyright from yourself + SCST developers is in
place in this patch, as well as my own copyright for the modern LLD
refactoring, forward-port and cleanups to work with mainline target
infrastructure.

I have no issues with including your's and other original author's names
for the pioneering work into the commit log for the next round of review
of PATCH #2, and am happy to make sure this is included for a future
squashed version of the series for a mainline commit.

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/