linux-kernel - Re: [PATCH 1/5] usb/gadget: cleanup of "Add SuperSpeed support to the Gadget Framework"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110413081732.GV15130@legolas.emea.dhcp.ti.com>
Date:	Wed, 13 Apr 2011 11:17:33 +0300
From:	Felipe Balbi <balbi@...com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:	Tatyana Brokhman <tlinder@...eaurora.org>, gregkh@...e.de,
	linux-arm-msm@...r.kernel.org, balbi@...com, ablay@...eaurora.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] usb/gadget: cleanup of "Add SuperSpeed support to
 the Gadget Framework"

Hi,

On Tue, Apr 12, 2011 at 09:34:52PM +0200, Sebastian Andrzej Siewior wrote:
> style, some endianess fixups
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>  drivers/usb/gadget/Kconfig     |    1 -
>  drivers/usb/gadget/composite.c |   62 +++++++++++++++++----------------------
>  include/linux/usb/gadget.h     |    2 +-
>  3 files changed, 28 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index b4130bc..21429c7 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -609,7 +609,6 @@ config USB_GADGET_SUPERSPEED
>  	boolean "Gadget operating in Super Speed"
>  	depends on USB_GADGET
>  	depends on USB_GADGET_DUALSPEED
> -	default n
>  	help
>  	  Enabling this feature enables Super Speed support in the Gadget
>  	  driver. It means that gadget drivers should provide extra (SuperSpeed)
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index d5fe1c2..a94b7b7 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -76,10 +76,7 @@ static char composite_manufacturer[50];
>  /* Default endpoint companion descriptor */
>  static struct usb_ss_ep_comp_descriptor default_ep_comp_desc = {
>  		.bDescriptorType = USB_DT_SS_ENDPOINT_COMP,
> -		.bLength = 0x06,
> -		.bMaxBurst = 0, /* the default is we don't support bursting */
> -		.bmAttributes = 0, /* 2^0 streams supported */
> -		.wBytesPerInterval = 0,
> +		.bLength = sizeof(struct usb_ss_ep_comp_descriptor),

actually, there's a define:

#define USB_DT_SS_EP_COMP_SIZE		6

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/