linux-kernel - Re: [PATCH 4/5] usb/gadget: don't deploy SS descriptors if SS is not enabled.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.vtvh5phh3l0zgt@mnazarewicz-glaptop>
Date:	Wed, 13 Apr 2011 12:59:39 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Sergei Shtylyov" <sshtylyov@...sta.com>,
	"Sebastian Andrzej Siewior" <bigeasy@...utronix.de>
Cc:	"Tatyana Brokhman" <tlinder@...eaurora.org>, gregkh@...e.de,
	linux-arm-msm@...r.kernel.org, balbi@...com, ablay@...eaurora.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] usb/gadget: don't deploy SS descriptors if SS is not
 enabled.

On Wed, 13 Apr 2011 12:56:57 +0200, Sebastian Andrzej Siewior  
<bigeasy@...utronix.de> wrote:

> Sergei Shtylyov wrote:
>> Hello.
>
> Hello Sergei,
>
>> Cleaned-up example:
>>  (in header)
>>     #ifndef CONFIG_NET_FUNKINESS
>>     static inline void init_funky_net (struct net_device *d) {}
>>     #endif
>>  (in the code itself)
>>     dev = alloc_etherdev (sizeof(struct funky_private));
>>     if (!dev)
>>         return -ENODEV;
>>     init_funky_net(dev);
>
> The problem here is that the code is included via
>
>    #include "composite.c
>
> so we don't really use header files. The alternative would be to use the
> gadget_is_super_speed() function but that one takes a gadget as argument.
> Preferences?

#ifdef CONFIG_USB_GADGET_SUPERSPEED
void usb_create_ss_descriptors(struct usb_function *f)
{
	/* ... */
}
#else
static inline void usb_create_ss_descriptors(struct usb_function *f) { }
#endif

Is usually preferred.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@...gle.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/