linux-kernel - Re: [PATCH] net: ipv4: add IPPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110413112210.GA6948@albatros>
Date:	Wed, 13 Apr 2011 15:22:10 +0400
From:	Vasiliy Kulikov <segoon@...nwall.com>
To:	David Miller <davem@...emloft.net>
Cc:	solar@...nwall.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, peak@...o.troja.mff.cuni.cz,
	kees.cook@...onical.com, dan.j.rosenberg@...il.com,
	eugene@...hat.com, nelhage@...lice.com, kuznet@....inr.ac.ru,
	pekkas@...core.fi, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net
Subject: Re: [PATCH] net: ipv4: add IPPROTO_ICMP socket kind

On Tue, Apr 12, 2011 at 14:25 -0700, David Miller wrote:
> I have no fundamental objections to this change and I'll be happy to
> apply it after we iron out a few details.

Great!

> First, please get rid of the debug option, we have pr_debug() which can
> be dynamically turned on and off at run time these days.

OK.

> Second, if this is a bonafide core facility we'd like everyone to use,
> let's make it so.  I want it so that every ping binary can expect this
> facility to be there if the kernel is new enough.
> 
> So let's get rid of the config option.

OK.

> Finally, longer term, I'd really like to see ipv6 support for this
> feature as well.

Definitely.

For ICMPv6 we should recognize what message types are OK to send by
non-root users and what types are privileged.  We just didn't do this
yet.


Thank you for the review,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/