linux-kernel - Re: [PATCH] [hwmon] lm90: Support NCT1008 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110413145321.181484bf@endymion.delvare>
Date:	Wed, 13 Apr 2011 14:53:21 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	wni@...dia.com
Cc:	guenter.roeck@...csson.com, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org, olofj@...omium.org, achew@...dia.com
Subject: Re: [PATCH] [hwmon] lm90: Support NCT1008 sensor

Hi Wei,

On Wed, 13 Apr 2011 19:51:48 +0800, wni@...dia.com wrote:
> From: Wei Ni <wni@...dia.com>
> 
> NCT1008 is the register-compatible with the ADM1032 and ADT7461,
> so support it in this lm90 driver.
> And add alarm function, suspend/resume callback.

We already have a patch pending adding support for the NCT1008:
ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-hwmon/hwmon-lm90-01-add-support-for-adt7461a-and-nct1008.patch

Your own patch should apply on top of this, and only focus on adding
support for the new features. BTW, you stand a better chance of getting
your changes reviewed and accepted quickly if you split them into
logical steps. For example, suspend/resume support would be useful on
its own, so it could be a separate patch, etc.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/