linux-kernel - Re: [patch v2 1/4] percpu_counter: change return value and add comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110413190554.GD3987@mtj.dyndns.org>
Date:	Thu, 14 Apr 2011 04:05:54 +0900
From:	Tejun Heo <tj@...nel.org>
To:	shaohua.li@...el.com
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	cl@...ux.com, eric.dumazet@...il.com
Subject: Re: [patch v2 1/4] percpu_counter: change return value and add
 comments

On Wed, Apr 13, 2011 at 03:57:16PM +0800, shaohua.li@...el.com wrote:
> the percpu_counter_*_positive() API SMP and UP aren't consistent. Add comments
> to explain it.
> Also if count < 0, returns 0 instead of 1 for *read_positive().
> 
> Signed-off-by: Shaohua Li <shaohua.li@...el.com>

Patch looks technically okay to me but may I suggest...

* Revise patch description.  It doesn't really match the patch
  content.

* I would much prefer having docbook comments on top of
  *read_positive() functions.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/