linux-kernel - Re: [PATCH 01/21] sched: Provide scheduler_ipi() callback in response to smp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1302730737.2388.129.camel@twins>
Date:	Wed, 13 Apr 2011 23:38:57 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Tony Luck <tony.luck@...el.com>
Cc:	Chris Mason <chris.mason@...cle.com>,
	Frank Rowand <frank.rowand@...sony.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Mike Galbraith <efault@....de>,
	Oleg Nesterov <oleg@...hat.com>, Paul Turner <pjt@...gle.com>,
	Jens Axboe <axboe@...nel.dk>,
	Yong Zhang <yong.zhang0@...il.com>,
	linux-kernel@...r.kernel.org,
	Russell King <rmk+kernel@....linux.org.uk>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Chris Metcalf <cmetcalf@...era.com>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH 01/21] sched: Provide scheduler_ipi() callback in
 response to smp_send_reschedule()

On Wed, 2011-04-13 at 14:15 -0700, Tony Luck wrote:
> On Tue, Apr 5, 2011 at 8:23 AM, Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
> > --- linux-2.6.orig/arch/ia64/kernel/irq_ia64.c
> > +++ linux-2.6/arch/ia64/kernel/irq_ia64.c
> > @@ -31,6 +31,7 @@
> >  #include <linux/irq.h>
> >  #include <linux/ratelimit.h>
> >  #include <linux/acpi.h>
> > +#include <linux/sched.h>
> >
> >  #include <asm/delay.h>
> >  #include <asm/intrinsics.h>
> > @@ -496,6 +497,7 @@ ia64_handle_irq (ia64_vector vector, str
> >                        smp_local_flush_tlb();
> >                        kstat_incr_irqs_this_cpu(irq, desc);
> >                } else if (unlikely(IS_RESCHEDULE(vector))) {
> > +                       scheduler_ipi();
> >                        kstat_incr_irqs_this_cpu(irq, desc);
> >                } else {
> >                        ia64_setreg(_IA64_REG_CR_TPR, vector);
> 
> This bit breaks ia64 CONFIG_SMP=n builds in next-20110413 with:
> 
> arch/ia64/kernel/irq_ia64.c: In function ‘ia64_handle_irq’:
> arch/ia64/kernel/irq_ia64.c:500: error: implicit declaration of
> function ‘scheduler_ipi’

Ah, I didn't think arch code would have the reschedule interrupt on UP.
I'll provide an empty stub. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/