linux-kernel - Re: [PATCH 3/4]percpu_counter: fix code for 32bit systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1302669428.3981.172.camel@sli10-conroe>
Date:	Wed, 13 Apr 2011 12:37:08 +0800
From:	Shaohua Li <shaohua.li@...el.com>
To:	"tj@...nel.org" <tj@...nel.org>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"cl@...ux.com" <cl@...ux.com>
Subject: Re: [PATCH 3/4]percpu_counter: fix code for 32bit systems

On Wed, 2011-04-13 at 11:50 +0800, tj@...nel.org wrote:
> Hello, guys.
> 
> On Wed, Apr 13, 2011 at 11:03:01AM +0800, Shaohua Li wrote:
> > I can do this, but please give a reason. If network code is the only
> > place requiring disable irq, why not network code do it?
> 
> This thread is pointless.  The next patch converts it to atomic64_t
> and the lock is removed anyway.  I think Eric's argument makes sense
> given that atomic64_t translates into irqsave spinlock (it has to) in
> generic 32bit implementation.  That said, this is all a moot point.
> We might as well simply drop this patch and directly convert to
> atomic64_t.
We need it for UP case anyway. Ok, I'll change it to irqsave in next
post.

Thanks,
Shaohua

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/