linux-kernel - Re: Re-send (What else needs to be done to the sep driver (staging/sep))

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110413222332.GA32013@kroah.com>
Date:	Wed, 13 Apr 2011 15:23:32 -0700
From:	Greg KH <greg@...ah.com>
To:	Joe Perches <joe@...ches.com>
Cc:	"Mark A. Allyn" <mark.a.allyn@...el.com>,
	linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	jayant.mangalampalli@...el.com, venkat.r.gokulrangan@...el.com
Subject: Re: Re-send (What else needs to be done to the sep driver
 (staging/sep))

On Wed, Apr 13, 2011 at 02:56:51PM -0700, Joe Perches wrote:
> On Wed, 2011-04-13 at 14:29 -0700, Mark A. Allyn wrote:
> > What else needs to be done to the sep driver in order for it to be moved 
> > to the kernel from staging?
> 
> Maybe a patch from you to move it?
> It seems pretty clean to me.
> Are you going to keep all the _dbg statements?
> 
> You might add a Kconfig CONFIG_SEP_DEBUG block with a
> Makefile entry of:
> ccflags-$(CONFIG_SEP_DEBUG) := -DDEBUG
> to specifically enable DEBUG without dynamic debug.
> 
> Here's a Kconfig typo fix and a suggestion to rename the
> uses of dev_dbg and dev_warn to sep_<level> to make the
> code a bit shorter and more compact.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> ---
> 
>  drivers/staging/sep/Kconfig      |    2 +-
>  drivers/staging/sep/sep_driver.c |  340 +++++++++++++++++---------------------
>  2 files changed, 152 insertions(+), 190 deletions(-)
> 
> diff --git a/drivers/staging/sep/Kconfig b/drivers/staging/sep/Kconfig
> index 92bf166..84c1b2b 100644
> --- a/drivers/staging/sep/Kconfig
> +++ b/drivers/staging/sep/Kconfig
> @@ -3,7 +3,7 @@ config DX_SEP
>  	depends on PCI
>  	help
>  	  Discretix SEP driver; used for the security processor subsystem
> -	  on bard the Intel Mobile Internet Device.
> +	  on board the Intel Mobile Internet Device.
>  
>  	  The driver's name is sep_driver.
>  
> diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
> index 890eede..d0537ca 100644
> --- a/drivers/staging/sep/sep_driver.c
> +++ b/drivers/staging/sep/sep_driver.c
> @@ -66,6 +66,11 @@
>  
>  #define SEP_RAR_IO_MEM_REGION_SIZE 0x40000
>  
> +#define sep_dbg(sep, fmt, ...)				\
> +	dev_dbg(&sep->pdev->dev, fmt, ##__VA_ARGS__)
> +#define sep_warn(sep, fmt, ...)				\
> +	dev_warn(&sep->pdev->dev, fmt, ##__VA_ARGS__)


Ick, no, never use your own macros, just use the "real" things like is
done in this driver.  If it's a pain to get to that pointer, then use a
temporary variable in the code and then use it.

Otherwise, no, I don't like this patch at all, sorry.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/