linux-kernel - Re: [PATCH] snd_hda_codec_realtek: enable ALC271 for Acer laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Apr 2011 11:45:13 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	"Guido Trentalancia" <guido@...ntalancia.com>
Cc:	linux-kernel@...r.kernel.org, kailang@...ltek.com.tw,
	pshou@...ltek.com.tw, jwoithe@...sics.adelaide.edu.au
Subject: Re: [PATCH] snd_hda_codec_realtek: enable ALC271 for Acer laptops

At Thu, 07 Apr 2011 19:38:27 +0200,
Guido Trentalancia wrote:
> 
> This quick fix to the Realtek HD Audio driver enables configurable support for the ALC271 type commonly found on some Acer laptops (e.g. Aspire 5745G).
> 
> Normally, the driver would fall back to BIOS auto-probing. However, the "model=acer" parameter can be passed on the boot command line to enable such support. Otherwise, it is quite common that the internal microphone does not work.

Well, adding the quirk label is fine, but this is no real fix.
I can apply it with a different subject.

Anyway, it's not such quite common that the machine doesn't work
without the model quirk any longer :)  In most cases, we want to avoid
the model quirk but fixing the pin configuration instead.

If the auto-parser doesn't work as is, please give alsa-info.sh output
on your machine, and give the exact description what doesn't actually
work.  Then we can fix in a better way.


thanks,

Takashi

> --- linux-2.6.38.2-original/sound/pci/hda/patch_realtek.c	2011-04-07 17:56:25.053046707 +0200
> +++ linux-2.6.38.2/sound/pci/hda/patch_realtek.c	2011-04-07 19:03:00.975706888 +0200
> @@ -15028,6 +15028,7 @@ static const char * const alc269_models[
>  	[ALC269_DMIC]			= "laptop-dmic",
>  	[ALC269_FUJITSU]		= "fujitsu",
>  	[ALC269_LIFEBOOK]		= "lifebook",
> +	[ALC271_ACER]			= "acer",
>  	[ALC269_AUTO]			= "auto",
>  };
>   
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/