linux-kernel - Re: [PATCH] x86: Clean up mwait_play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1302781481.13300.31.camel@mendozza.osrc.amd.com>
Date:	Thu, 14 Apr 2011 13:44:41 +0200
From:	Frank Arnold <frank.arnold@....com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Borislav Petkov <bp@...64.org>, "H. Peter Anvin" <hpa@...or.com>,
	Frank Arnold <farnold@...64.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: Clean up mwait_play_dead

On Wed, 2011-04-13 at 13:49 -0400, Ingo Molnar wrote:
> * Borislav Petkov <bp@...64.org> wrote:
> 
> > On Wed, Apr 13, 2011 at 09:52:40AM -0700, H. Peter Anvin wrote:
> > > On 04/13/2011 09:11 AM, Frank Arnold wrote:
> > > > From: Frank Arnold <frank.arnold@....com>
> > > > 
> > > > Commit 93789b32dbf355e70f18b17a82e8661677a7f7fb introduced
> > > > cpuinfo_x86 *c for brevity. It is used to check for the
> > > > mwait feature flag. The same can be done with a subsequent
> > > > check for clflsh and save us a second per-cpu pointer
> > > > dereference.
> > > > 
> > > > Signed-off-by: Frank Arnold <frank.arnold@....com>
> > > > Acked-by: Borislav Petkov <borislav.petkov@....com>
> > > > ---
> > > >  arch/x86/kernel/smpboot.c |    2 +-
> > > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > > 
> > > 
> > > This should be using this_cpu_has()... if that's not in the tree yet we
> > > should add it.
> > 
> > Looks like it is still in tip/x86/mm.
> 
> Yeah - that patch was sent at around the beginning of the merge window, so it 
> was too late for .39.
> 
> > We could either redo the patch properly when this_cpu_has() is merged or add 
> > the change against that branch.
> 
> Yeah - please do one against tip:master and we'll put it into the right topic 
> branch.

It's already fixed in tip:master with the proper use of this_cpu_has().
commit 349c004e3d31fda23ad225b61861be38047fff16

Sorry for the noise.

-- 
Frank.

Advanced Micro Devices GmbH
Sitz: Dornach, Gemeinde Aschheim,
Landkreis München Registergericht München,
HRB Nr. 43632 - WEEE Registrierungsnummer 129 19551
Geschäftsführer: Alberto Bozzo, Andrew Bowd


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/