| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110414130626.GA7890@opensource.wolfsonmicro.com> Date: Thu, 14 Apr 2011 06:06:26 -0700 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Antonio Ospite <ospite@...denti.unina.it> Cc: Johannes Berg <johannes@...solutions.net>, linux-wireless@...r.kernel.org, openezx-devel@...ts.openezx.org, "John W . Linville" <linville@...driver.com>, linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>, Guiming Zhuo <gmzhuo@...il.com> Subject: Re: [PATCH v3] rfkill: Regulator consumer driver for rfkill On Thu, Apr 14, 2011 at 12:39:12PM +0200, Antonio Ospite wrote: > Johannes Berg <johannes@...solutions.net> wrote: > > Should remove do platform_set_drvdata(pdev, NULL)? > AFAICS this is not strictly necessary because we never check for NULL > here and we are setting drvdata again in _probe() each time the module > is loaded anyways. If it is considered a good practice for symmetry > reasons then I'll add it, no problem. Does anyone has comments on that? We went round this loop with I2C - anything peering at driver data that it didn't originally set is buggy anyway so no need to reset to zero. If there was a need the platform bus or driver core should do it since all devices would need it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists