linux-kernel - Re: [PATCH] char: agp: fix OOM and buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimNgb+5W4kjKiarRAU=EH=X=_vUzQ@mail.gmail.com>
Date:	Thu, 14 Apr 2011 21:07:36 +0400
From:	Vasiliy Kulikov <segooon@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: agp: fix OOM and buffer overflow

> -       if ((atomic_read(&bridge->current_memory_agp) + page_count) > bridge->max_memory_agp)
> +       cur_memory = atomic_read(&bridge->current_memory_agp);
> +       if ((cur_memory + page_count > bridge->max_memory_agp) ||
> +           (cur_memory + page_count < page_count))
I should have said that current_memory_agp is already protected by
agp_fe.agp_mutex, so the patch doesn't break atomic operation
(otherwise there is also a race between the check and use of
current_memory_agp).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/