linux-kernel - Re: [PATCH 3/4] TPS65910: IRQ: Add interrupt controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Apr 2011 14:05:18 -0500
From:	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, broonie@...nsource.wolfsonmicro.com,
	lrg@...com, sameo@...ux.intel.com
Subject: Re: [PATCH 3/4] TPS65910: IRQ: Add interrupt controller

Hi Thomas,
On Apr 14, 2011, at 11:22 AM, Thomas Gleixner wrote:

> On Thu, 14 Apr 2011, Jorge Eduardo Candelaria wrote:
>> +static void tps65910_irq_lock(unsigned int irq)
>> +static void tps65910_irq_sync_unlock(unsigned int irq)
>> +static void tps65910_irq_enable(unsigned int irq)
>> +static void tps65910_irq_disable(unsigned int irq)
>> +
>> +static struct irq_chip tps65910_irq_chip = {
>> +	.name = "tps65910",
>> +	.irq_bus_lock = tps65910_irq_lock,
>> +	.irq_bus_sync_unlock = tps65910_irq_sync_unlock,
>> +	.irq_disable = tps65910_irq_disable,
>> +	.irq_enable = tps65910_irq_enable,
>> +};
> 
> Care to explain how that compiles?

I didn't notice it because there was no compilation error, however, I failed to
see the following warnings:

drivers/mfd/tps65910-irq.c:124: warning: initialization from incompatible pointer type
drivers/mfd/tps65910-irq.c:125: warning: initialization from incompatible pointer type
drivers/mfd/tps65910-irq.c:126: warning: initialization from incompatible pointer type
drivers/mfd/tps65910-irq.c:127: warning: initialization from incompatible pointer type

I'm changing this for v2.

Thanks,
Jorge

> 
> Thanks,
> 
> 	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/