linux-kernel - Re: [PATCH] snd_hda_codec_realtek: enable ALC271 for Acer laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h62qgd426.wl%tiwai@suse.de>
Date:	Thu, 14 Apr 2011 21:29:53 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Guido Trentalancia <guido@...ntalancia.com>
Cc:	linux-kernel@...r.kernel.org, kailang@...ltek.com.tw,
	pshou@...ltek.com.tw, jwoithe@...sics.adelaide.edu.au
Subject: Re: [PATCH] snd_hda_codec_realtek: enable ALC271 for Acer laptops

At Thu, 14 Apr 2011 18:59:27 +0200,
Guido Trentalancia wrote:
> 
> Hello Takashi.
> 
> On Thu, 2011-04-14 at 11:45 +0200, Takashi Iwai wrote:
> > At Thu, 07 Apr 2011 19:38:27 +0200,
> > Guido Trentalancia wrote:
> > > 
> > > This quick fix to the Realtek HD Audio driver enables configurable support for the ALC271 type commonly found on some Acer laptops (e.g. Aspire 5745G).
> > > 
> > > Normally, the driver would fall back to BIOS auto-probing. However, the "model=acer" parameter can be passed on the boot command line to enable such support. Otherwise, it is quite common that the internal microphone does not work.
> > 
> > Well, adding the quirk label is fine, but this is no real fix.
> > I can apply it with a different subject.
> 
> Yes, it wasn't meant to be a definitive fix. This is because I am no
> expert in that specific driver. I just bought the Acer Aspire 5745G and
> found that the internal microphone was not working. So I tried to find a
> quick fix and when I found it I thought other users might benefit from
> it. As simple as that.
> 
> The idea was more or less to have that applied as soon as possible so
> that things are not broken for that class of users and then have
> somebody with more expertise in the driver to fix it in the proper way
> when possible.

Yes, so I'm not against to expose the model name in the list.
What I wondered is just the disparity between the subject and the
patch you posted.

> > Anyway, it's not such quite common that the machine doesn't work
> > without the model quirk any longer :)  In most cases, we want to avoid
> > the model quirk but fixing the pin configuration instead.
> > 
> > If the auto-parser doesn't work as is, please give alsa-info.sh output
> > on your machine, and give the exact description what doesn't actually
> > work.  Then we can fix in a better way.
> 
> That's fine. What is broken is the internal microphone (this was stated
> somewhere in the original message). In practice, I think the pin
> configuration fails (vanilla 2.6.38.2).

Did you try 2.6.39?  How did you test the internal mic at all?
Which sound backend is being used on your system?

As the first start, please give alsa-info.sh output (run with
--no-upload option) without model option.  This will give more
information of your system.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/