linux-kernel - Re: [Regression] 2.6.38 ncpfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTikMyokqzTm=-bqymePwbgmEar=qhQ@mail.gmail.com>
Date:	Thu, 14 Apr 2011 13:22:38 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Bongani Hlope <bonganilinux@...b.co.za>
Cc:	npiggin@...nel.dk, "Rafael J. Wysocki" <rjw@...k.pl>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Greg KH <greg@...ah.com>,
	"Dr. Bernd Feige" <bernd.feige@...klinik-freiburg.de>,
	Petr Vandrovec <petr@...drovec.name>,
	Arnd Bergmann <arnd@...db.de>, Christoph Hellwig <hch@....de>
Subject: Re: [Regression] 2.6.38 ncpfs

On Thu, Apr 14, 2011 at 1:17 PM, Bongani Hlope <bonganilinux@...b.co.za> wrote:
>
> Looking at the changes,  you are right. The BUG_ON() seems to be what is not
> suppose to be there. The attached patch only removes the BUG_ON(). I'll test
> on my work PC tomorrow and see if that also fixes the bug.

You might also try to replace it with

    BUG_ON(!mutex_is_locked(&dentry->d_parent->d_inode->i_mutex))

ie add that "d_parent" there. Just for testing - I think the real fix
really is to remove it, but I'd personally be happier knowing that
_if_ it were to have that d_parent there, it would have worked.

It would also be interesting to hear if that name length could
possibly ever change, and we'd hit that test too. It looks like the
original code actually checked that the length was the same before
doing the overwrite.

ncpfs doesn't seem to be very actively maintained, I suspect Petr
isn't really using it any more.

                   Linus

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/