linux-kernel - Re: Regression from 2.6.36

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Apr 2011 08:31:58 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Changli Gao <xiaosuo@...il.com>,
	Américo Wang <xiyou.wangcong@...il.com>,
	Jiri Slaby <jslaby@...e.cz>, azurIt <azurit@...ox.sk>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-fsdevel@...r.kernel.org, Jiri Slaby <jirislaby@...il.com>,
	Mel Gorman <mel@....ul.ie>
Subject: Re: Regression from 2.6.36

Le mercredi 13 avril 2011 à 22:28 -0700, Andrew Morton a écrit :
> On Thu, 14 Apr 2011 04:10:58 +0200 Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
> > > --- a/fs/file.c~a
> > > +++ a/fs/file.c
> > > @@ -39,14 +39,17 @@ int sysctl_nr_open_max = 1024 * 1024; /*
> > >   */
> > >  static DEFINE_PER_CPU(struct fdtable_defer, fdtable_defer_list);
> > >  
> > > -static inline void *alloc_fdmem(unsigned int size)
> > > +static void *alloc_fdmem(unsigned int size)
> > >  {
> > > -	void *data;
> > > -
> > > -	data = kmalloc(size, GFP_KERNEL|__GFP_NOWARN);
> > > -	if (data != NULL)
> > > -		return data;
> > > -
> > > +	/*
> > > +	 * Very large allocations can stress page reclaim, so fall back to
> > > +	 * vmalloc() if the allocation size will be considered "large" by the VM.
> > > +	 */
> > > +	if (size <= (PAGE_SIZE << PAGE_ALLOC_COSTLY_ORDER) {
> > > +		void *data = kmalloc(size, GFP_KERNEL|__GFP_NOWARN);
> > > +		if (data != NULL)
> > > +			return data;
> > > +	}
> > >  	return vmalloc(size);
> > >  }
> > >  
> > > _
> > > 
> > 
> > Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> > 
> > #define PAGE_ALLOC_COSTLY_ORDER 3
> > 
> > On x86_64, this means we try kmalloc() up to 4096 files in fdtable.
> 
> Thanks.  I added the cc:stable to the changelog.
> 
> It'd be nice to get this tested if poss, to confrm that it actually
> fixes things.
> 
> Also, Melpoke.

Azurit, could you check how many fds are opened by your apache servers ?
(must be related to number of virtual hosts / acces_log / error_log
files)

Pick one pid from ps list
ps aux | grep apache

ls /proc/{pid_of_one_apache}/fd | wc -l

or

lsof -p { pid_of_one_apache} | tail -n 2
apache2 8501 httpadm   13w   REG     104,7  2350407   3866638 /data/logs/httpd/rewrites.log
apache2 8501 httpadm   14r  0000      0,10        0 263148343 eventpoll

Here it's "14"

Thanks


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/