linux-kernel - Re: [PATCH v4 2/2] apic: Add print error interrupt reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Apr 2011 11:54:12 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Youquan Song <youquan.song@...el.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com,
	hpa@...ux.intel.com, suresh.b.siddha@...el.com,
	yong.y.wang@...ux.intel.com, joe@...ches.com, jbaron@...hat.com,
	trenn@...e.de, kent.liu@...el.com, chaohong.guo@...el.com,
	Youquan Song <youquan.song@...ux.intel.com>
Subject: Re: [PATCH v4 2/2] apic: Add print error interrupt reason

On Thu, Apr 14, 2011 at 10:36 AM, Youquan Song <youquan.song@...el.com> wrote:
> End user worry about the error interrupt information and intend to know what
> kind of error interrupts are generated, so this patch add printing out the
> detail debug information of error interrupt.
> dynamic debug is not initiated when LAPIC initiation, so the pr_debug will not
> output the error interrupt debug information when boot.
> In this patch, we use apic_printk(APIC_DEBUG,), so if add kernel option
> apic=debug will output the error interrupt during boot.
>
> Signed-off-by: Youquan Song <youquan.song@...el.com>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  arch/x86/kernel/apic/apic.c |   38 +++++++++++++++++++++++++-------------
>  1 files changed, 25 insertions(+), 13 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index fabf01e..3ddf4ef 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1813,6 +1813,17 @@ void smp_spurious_interrupt(struct pt_regs *regs)
>  void smp_error_interrupt(struct pt_regs *regs)
>  {
>        u32 v, v1;
> +       u32 i = 0;
> +       static const char * const error_interrupt_reason[] = {
> +               "Send CS error",                /* APIC Error Bit 0 */
> +               "Receive CS error",             /* APIC Error Bit 1 */
> +               "Send accept error",            /* APIC Error Bit 2 */
> +               "Receive accept error",         /* APIC Error Bit 3 */
> +               "Redirectable IPI",             /* APIC Error Bit 4 */
> +               "Send illegal vector",          /* APIC Error Bit 5 */
> +               "Received illegal vector",      /* APIC Error Bit 6 */
> +               "Illegal register address",     /* APIC Error Bit 7 */
> +       };
>
...
> -       pr_debug("APIC error on CPU%d: %02x(%02x)\n",
> -               smp_processor_id(), v , v1);
> +       apic_printk(APIC_DEBUG, KERN_DEBUG "APIC error on CPU%d: %02x(%02x)",
> +                   smp_processor_id(), v , v1);
> +
> +       v1 = v1 & 0xff;
> +       while (v1) {
> +               if (v1 & 0x1)
> +                       apic_printk(APIC_DEBUG, KERN_CONT " : %s",
> +                                   error_interrupt_reason[i]);
> +               i++;
> +               v1 >>= 1;
> +       };
> +

Hi looks good but please add some array-checking in case if we get
some damaged result
from hardware, ie check for i not being out of error_interrupt_reason. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/