linux-kernel - Re: [tip:perf/core] perf evsel: Fix inverted test for fixing up attr.inherit flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1302865926.2388.238.camel@twins>
Date:	Fri, 15 Apr 2011 13:12:06 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
Cc:	mingo@...hat.com, hpa@...or.com, paulus@...ba.org,
	eranian@...gle.com, linux-kernel@...r.kernel.org,
	tzanussi@...il.com, efault@....de, fweisbec@...il.com,
	dsahern@...il.com, tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] perf evsel: Fix inverted test for fixing up
 attr.inherit flag

On Thu, 2011-04-14 at 14:01 -0300, Arnaldo Carvalho de Melo wrote:
> 
> There was another, sillier problem, now seems to work, ack?
> 
> [acme@...lia linux]$ perf stat ~/loop_1b_instructions-4x
> 
>  Performance counter stats for '/home/acme/loop_1b_instructions-4x':
> 
>        1451.781634 task-clock-msecs         #      3.965 CPUs 
>              1,463 context-switches         #      0.001 M/sec
>                  3 CPU-migrations           #      0.000 M/sec
>                187 page-faults              #      0.000 M/sec
>      2,865,021,951 cycles                   #   1973.452 M/sec  (scaled from 70.29%)
>      4,001,127,146 instructions             #      1.397 IPC    (scaled from 80.24%)
>        401,476,915 branches                 #    276.541 M/sec  (scaled from 80.27%)
>             63,800 branch-misses            #      0.016 %      (scaled from 80.29%)
>            262,866 cache-references         #      0.181 M/sec  (scaled from 20.14%)
>             10,938 cache-misses             #      0.008 M/sec  (scaled from 20.07%)
> 
>         0.366184692  seconds time elapsed
> 
> [acme@...lia linux]$
> 
> From 41d8ff6c4be9216cae74dd82381d9f486e82bf22 Mon Sep 17 00:00:00 2001
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
> Date: Thu, 14 Apr 2011 11:20:14 -0300
> Subject: [PATCH] perf evsel: Fix use of inherit
> 
> perf stat doesn't mmap and its perfectly fine for it to use task-bound
> counters with inheritance.
> 
> So set the attr.inherit on the caller and leave the syscall itself to
> validate it.
> 
> When the mmap fails perf_evlist__mmap will just emit a warning if this
> is the failure reason.
> 
> Reported-by: Peter Zijlstra <peterz@...radead.org>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Mike Galbraith <efault@....de>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Stephane Eranian <eranian@...gle.com>
> Cc: Tom Zanussi <tzanussi@...il.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com> 

Yay works!

Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/