lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20110415163001.GD11454@atrey.karlin.mff.cuni.cz>
Date:	Fri, 15 Apr 2011 18:30:02 +0200
From:	Pavel Machek <pavel@....cz>
To:	Timothy Courrejou <timcour@...il.com>
Cc:	lenb@...nel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ACPI: ac: fixed indentation, commenting and line
	length coding style issues

Hi!

> Fixed coding style issues.
> 
> Signed-off-by: Timothy Courrejou <timcour@...il.com>
> ---
>  drivers/acpi/ac.c |   36 ++++++++++++++++++------------------
>  1 files changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 183a035..58c3f74 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -85,7 +85,7 @@ static struct acpi_driver acpi_ac_driver = {
>  
>  struct acpi_ac {
>  	struct power_supply charger;
> -	struct acpi_device *device;
> +	struct acpi_device * device;
>  	unsigned long long state;

This _adds_ coding style issue.


>  };
>  
> @@ -101,9 +101,10 @@ static const struct file_operations acpi_ac_fops = {
>  };
>  #endif
>  
> -/*
> - * AC Adapter Management
> - */
> +/* --------------------------------------------------------------------------
> +                               AC Adapter Management
> +   -------------------------------------------------------------------------- */
> +
>  static int acpi_ac_get_state(struct acpi_ac *ac)
>  {
>  	acpi_status status = AE_OK;

Reversed patch?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ