linux-kernel - Re: [PATCH v6 0/2] Make all it87 drivers SMP safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <25810A23-EB28-4FBF-8CEB-487313F0E16E@wilsonet.com>
Date:	Fri, 15 Apr 2011 17:07:03 -0400
From:	Jarod Wilson <jarod@...sonet.com>
To:	Nat Gurumoorthy <natg@...gle.com>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Guenter Roeck <guenter.roeck@...csson.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Mike Waychison <mikew@...gle.com>, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	"Juan Jesús García de Soria" 
	<skandalfo@...il.com>
Subject: Re: [PATCH v6 0/2] Make all it87 drivers SMP safe

On Apr 14, 2011, at 5:36 PM, Nat Gurumoorthy wrote:

> There are 3 different drivers that touch the it87 hardware registers.
> The 3 drivers have been written independently and access the it87 hardware
> registers assuming they are the only driver accessing it. This change
> attempts to serialize access to the hardware by using
> "request_muxed_region" macro defined by Alan Cox. Call to this macro
> will hold off the requestor if the resource is currently busy.
> The use of the above macro makes it possible to get rid of
> spinlocks in it8712f_wdt.c and it87_wdt.c watchdog drivers.
> This also greatly simplifies the implementation of it87_wdt.c driver.
> 
> 01 - Changes to it87 watchdog driver to use "request_muxed_region"
> drivers/watchdog/it8712f_wdt.c
> drivers/watchdog/it87_wdt.c
> 
> 02 - Chages to hwmon it87 driver to use "request_muxed_region"
> drivers/hwmon/it87.c
> 
> drivers/hwmon/it87.c           |   30 +++++++++++++-
> drivers/watchdog/it8712f_wdt.c |   50 +++++++++++++++++++++---
> drivers/watchdog/it87_wdt.c    |   80 +++++++++++++++++++++------------------
> 3 files changed, 113 insertions(+), 47 deletions(-)

FYI,

$ head -n 4 drivers/media/rc/ite-cir.c
/*
 * Driver for ITE Tech Inc. IT8712F/IT8512 CIR
 *
 * Copyright (C) 2010 Juan Jesús García de Soria <skandalfo@...il.com>


-- 
Jarod Wilson
jarod@...sonet.com



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/