lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Apr 2011 17:29:00 +0900 (JST) From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> To: Michal Hocko <mhocko@...e.cz> Cc: kosaki.motohiro@...fujitsu.com, LKML <linux-kernel@...r.kernel.org>, Jack Steiner <steiner@....com>, Lee Schermerhorn <lee.schermerhorn@...com>, Christoph Lameter <cl@...ux-foundation.org>, Pekka Enberg <penberg@...helsinki.fi>, Paul Menage <menage@...gle.com>, Robin Holt <holt@....com>, Andrew Morton <akpm@...ux-foundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, linux-mm@...ck.org Subject: Re: [PATCH v2] cpusets: randomize node rotor used in cpuset_mem_spread_node() > [I just realized that I forgot to CC mm mailing list] > > On Fri 15-04-11 16:18:45, KOSAKI Motohiro wrote: > > Oops. > > I should have look into !mempolicy part too. > > I'm sorry. > > > [...] > > Michal, I think this should be > > > > #ifdef CONFIG_CPUSETS > > if (cpuset_do_page_mem_spread()) > > p->cpuset_mem_spread_rotor = node_random(&p->mems_allowed); > > if (cpuset_do_slab_mem_spread()) > > p->cpuset_slab_spread_rotor = node_random(&p->mems_allowed); > > #endif > > > > because 99.999% people don't use cpuset's spread mem/slab feature and > > get_random_int() isn't zero cost. > > > > What do you think? > > You are right. I was thinking about lazy approach and initialize those > values when they are used for the first time. What about the patch > below? > > Change from v1: > - initialize cpuset_{mem,slab}_spread_rotor lazily Yeah! This is much much better than mine. Thank you! Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists