linux-kernel - Re: [PATCH]drivers:regulator:change the dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110416175440.GD25811@opensource.wolfsonmicro.com>
Date:	Sat, 16 Apr 2011 18:54:40 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	wanlong.gao@...il.com
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org,
	lrg@...mlogic.co.uk
Subject: Re: [PATCH]drivers:regulator:change the dev_dbg in the probe function

On Sat, Apr 16, 2011 at 11:42:23PM +0800, wanlong.gao@...il.com wrote:

Please ensure that you use subject lines for your patch which fit in
with the style of other changes to the subsystem.

> change the function name string to "%s".

You should also explain why a change is being made, not what the change
is (we can see that from the patch).  In this case what you're doing is
making this debug statement be consistent with the style of the rest of
the file.

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/