linux-kernel - RE: [PATCH 12/13] regulator: check name in initialization of max8925

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25B60CDC2F704E4E9D88FFD52780CB4C05CF05B23D@SC-VEXCH1.marvell.com>
Date:	Mon, 18 Apr 2011 06:49:44 -0700
From:	Haojian Zhuang <hzhuang1@...vell.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"haojian.zhuang@...il.com" <haojian.zhuang@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lrg@...mlogic.co.uk>
Subject: RE: [PATCH 12/13] regulator: check name in initialization of max8925



>-----Original Message-----
>From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
>Sent: 2011年4月17日 2:02 AM
>To: Haojian Zhuang
>Cc: sameo@...ux.intel.com; haojian.zhuang@...il.com; linux-
>kernel@...r.kernel.org; Liam Girdwood
>Subject: Re: [PATCH 12/13] regulator: check name in initialization of
>max8925
>
>On Wed, Apr 13, 2011 at 10:51:03PM +0800, Haojian Zhuang wrote:
>> Check name in initialization of max8925 regulator driver.
>
>> +		if (!strcmp(ri->desc.name, pdata->constraints.name))
>> +			break;
>
>This isn't a good change - the whole point of the name in the
>constraints is that it allows the user to assign an arbatrary string
>which is useful for the board.  The driver should never be looking
>inside the constraints at all, the core will apply the constraints for
>you.

I'll move the name of regulator into regulator_init_data->driver_data.

Thanks
Haojian