linux-kernel - Re: [PATCH 14/14] regulator: 88pm8607: avoid to use constraint name in driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Apr 2011 15:30:45 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Haojian Zhuang <haojian.zhuang@...vell.com>
Cc:	sameo@...ux.intel.com, haojian.zhuang@...il.com,
	linux-kernel@...r.kernel.org, dmitry.torokhov@...il.com,
	a.zummo@...ertech.it, johnpol@....mipt.ru, cbou@...l.ru,
	dwmw2@...radead.org, lrg@...mlogic.co.uk
Subject: Re: [PATCH 14/14] regulator: 88pm8607: avoid to use constraint
 name in driver

On Mon, Apr 18, 2011 at 10:04:11PM +0800, Haojian Zhuang wrote:
> Avoid to use constraint name in driver. So use driver_data instead to
> store regulator name in platform driver.

If this is something that's present in the current driver it should be
fixed for 2.6.39 so should be a patch at the start of the series which
can be applied separately to the others.

> +		/* pdata->driver_data stores the name of regulator */
> +		if (!strcmp(info->desc.name, pdata->driver_data))
>  			break;

Why not just use #defines in the header?  It'd be less error prone if
nothing else.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/