linux-kernel - Re: [PATCH 1/1] drivers/usb/image/mdc800.c: Remove "typdef enum".

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110418042828.GA1904@gmail.com>
Date:	Mon, 18 Apr 2011 12:28:30 +0800
From:	Harry Wei <jiaweiwei.xiyou@...il.com>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	linux-kernel@...r.kernel.org, wanlong.gao@...il.com
Subject: Re: [PATCH 1/1] drivers/usb/image/mdc800.c: Remove "typdef enum".

On Sun, Apr 17, 2011 at 07:34:14PM -0300, Thiago Farina wrote:
> Instead use the keyword "enum" where we use it.
> 
> Signed-off-by: Thiago Farina <tfransosi@...il.com>
> ---
>  drivers/usb/image/mdc800.c |  111 +++++++++++++++++++++----------------------
This is well for me.
>  	NOT_CONNECTED, READY, WORKING, DOWNLOAD
> -} mdc800_state;
> +};
>  
>  
> -/* Data for the driver */
> +/* Data for the driver. */
>  struct mdc800_data
>  {
> -	struct usb_device *	dev;			// Device Data
> -	mdc800_state 		state;
> +	struct usb_device*      dev;                  /* Device Data. */
This should be 'struct usb_device	*dev'. The same as
following. See Documentation/CodingStyle for details.
> +	enum mdc800_state	state;
>  
> -	unsigned int		endpoint [4];
> +	unsigned int		endpoint[4];
>  
> -	struct urb *		irq_urb;
> +	struct urb*             irq_urb;
>  	wait_queue_head_t	irq_wait;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/