linux-kernel - Re: [PATCH] block: add blk_run_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikOKji3_p+bqMO4zoSnXFunEdue0g@mail.gmail.com>
Date:	Mon, 18 Apr 2011 15:55:04 -0400
From:	Mike Snitzer <snitzer@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	jaxboe@...ionio.com, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: add blk_run_queue_async

On Mon, Apr 18, 2011 at 5:26 AM, Christoph Hellwig <hch@...radead.org> wrote:
> Instead of overloading __blk_run_queue to force an offload to kblockd
> add a new blk_run_queue_async helper to do it explicitly.  I've kept
> the blk_queue_stopped check for now, but I suspect it's not needed
> as the check we do when the workqueue items runs should be enough.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
>
> Index: linux-2.6/block/blk-core.c
> ===================================================================
> --- linux-2.6.orig/block/blk-core.c     2011-04-18 10:48:11.010100413 +0200
> +++ linux-2.6/block/blk-core.c  2011-04-18 10:57:56.340262741 +0200
...
> @@ -317,6 +315,20 @@ void __blk_run_queue(struct request_queu
>  EXPORT_SYMBOL(__blk_run_queue);
>
>  /**
> + * blk_run_queue_async - run a single device queue in workqueue context
> + * @q: The queue to run
> + *
> + * Description:
> + *    Tells kblockd to perform the equivalent of @blk_run_queue on behalf
> + *    of us.
> + */
> +void blk_run_queue_async(struct request_queue *q)
> +{
> +       if (likely(!blk_queue_stopped(q)))
> +               queue_delayed_work(kblockd_workqueue, &q->delay_work, 0);

I know Jens already queued this up 'for-linus' but why not use
kblockd_schedule_work(q, &q->delay_work)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/