linux-kernel - Re: [PATCH] nconfig: Silence unused return values from wattrset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Apr 2011 15:38:56 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Michal Marek <mmarek@...e.cz>, Roman Zippel <zippel@...ux-m68k.org>
CC:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	Nir Tzachar <nir.tzachar@...il.com>
Subject: Re: [PATCH] nconfig: Silence unused return values from wattrset

On 04/06/2011 03:07 PM, Stephen Boyd wrote:
> Ignore the return value from wattrset since we ignore the return
> value in nconf.gui.c as well.
>
> scripts/kconfig/nconf.c: In function 'print_function_line':
> scripts/kconfig/nconf.c:376: warning: value computed is not used
> scripts/kconfig/nconf.c:380: warning: value computed is not used
> scripts/kconfig/nconf.c:387: warning: value computed is not used
> scripts/kconfig/nconf.c: In function 'show_menu':
> scripts/kconfig/nconf.c:956: warning: value computed is not used
> scripts/kconfig/nconf.c:961: warning: value computed is not used
> scripts/kconfig/nconf.c:963: warning: value computed is not used
> scripts/kconfig/nconf.c:965: warning: value computed is not used
>
> Cc: Nir Tzachar <nir.tzachar@...il.com>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---

Ping? Nack? Ack?

>  scripts/kconfig/nconf.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index db56377..488dd74 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -373,18 +373,18 @@ static void print_function_line(void)
>  	const int skip = 1;
>  
>  	for (i = 0; i < function_keys_num; i++) {
> -		wattrset(main_window, attributes[FUNCTION_HIGHLIGHT]);
> +		(void) wattrset(main_window, attributes[FUNCTION_HIGHLIGHT]);
>  		mvwprintw(main_window, LINES-3, offset,
>  				"%s",
>  				function_keys[i].key_str);
> -		wattrset(main_window, attributes[FUNCTION_TEXT]);
> +		(void) wattrset(main_window, attributes[FUNCTION_TEXT]);
>  		offset += strlen(function_keys[i].key_str);
>  		mvwprintw(main_window, LINES-3,
>  				offset, "%s",
>  				function_keys[i].func);
>  		offset += strlen(function_keys[i].func) + skip;
>  	}
> -	wattrset(main_window, attributes[NORMAL]);
> +	(void) wattrset(main_window, attributes[NORMAL]);
>  }
>  
>  /* help */
> @@ -953,16 +953,16 @@ static void show_menu(const char *prompt, const char *instructions,
>  	current_instructions = instructions;
>  
>  	clear();
> -	wattrset(main_window, attributes[NORMAL]);
> +	(void) wattrset(main_window, attributes[NORMAL]);
>  	print_in_middle(stdscr, 1, 0, COLS,
>  			menu_backtitle,
>  			attributes[MAIN_HEADING]);
>  
> -	wattrset(main_window, attributes[MAIN_MENU_BOX]);
> +	(void) wattrset(main_window, attributes[MAIN_MENU_BOX]);
>  	box(main_window, 0, 0);
> -	wattrset(main_window, attributes[MAIN_MENU_HEADING]);
> +	(void) wattrset(main_window, attributes[MAIN_MENU_HEADING]);
>  	mvwprintw(main_window, 0, 3, " %s ", prompt);
> -	wattrset(main_window, attributes[NORMAL]);
> +	(void) wattrset(main_window, attributes[NORMAL]);
>  
>  	set_menu_items(curses_menu, curses_menu_items);
>  
-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/