linux-kernel - Re: [PATCH 2/2] drm: Verify debug message arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1303168151.31723.50.camel@Joe-Laptop>
Date:	Mon, 18 Apr 2011 16:09:11 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ian Romanick <idr@...edesktop.org>
Cc:	David Airlie <airlied@...ux.ie>,
	Chris Wilson <chris@...is-wilson.co.uk>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 2/2] drm: Verify debug message arguments

On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:
> > @@ -214,9 +214,9 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv,
> >  	    i915_lvds_downclock) {
> >  		dev_priv->lvds_downclock_avail = 1;
> >  		dev_priv->lvds_downclock = temp_downclock;
> > -		DRM_DEBUG_KMS("LVDS downclock is found in VBT. ",
> > -				"Normal Clock %dKHz, downclock %dKHz\n",
> > -				temp_downclock, panel_fixed_mode->clock);
> > +		DRM_DEBUG_KMS("LVDS downclock is found in VBT. "
> > +			      "Normal Clock %dKHz, downclock %dKHz\n",
> > +			      temp_downclock, panel_fixed_mode->clock);
> >  	}
> >  	return;
> >  }
> Does this hunk only change white space, or am I missing something?

No, you're right.  It's just whitespace.
I prefer arguments aligned to open paren.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/