linux-kernel - Re: [PATCH 2/3] x86, cpu: Clean up and unify the NOP selection infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DACCBB0.2060804@linux.intel.com>
Date:	Mon, 18 Apr 2011 16:39:28 -0700
From:	"H. Peter Anvin" <hpa@...ux.intel.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	linux-kernel@...r.kernel.org, Jason Baron <jbaron@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>, tglx@...utronix.de,
	mingo@...e.hu, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 2/3] x86, cpu: Clean up and unify the NOP selection infrastructure

On 04/18/2011 04:31 PM, Steven Rostedt wrote:
> 
> Can we please add a comment to this. The original (above) was confusing
> enough, but at least it used asm() so it wasn't that bad to figure out.
> Or at least the asm() usage would trigger in one's mind to think "Damn!
> They chose to use 'asm', it must be some kind of nasty trick. Let's take
> a better look at WTF they are doing!".
> 
> Now the use a normal character array actual makes this even more subtle.

OK... I never thought it was particularly subtle, but okay.

A much bigger issue with this particular patch is that the
__init{data,const}_or_module presumably needs to be removed from these
structures, right?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/