linux-kernel - Re: LOCALVERSION in setlocalversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikspr9jVNF-VZbnc_MxUYNWad7Kkg@mail.gmail.com>
Date:	Tue, 19 Apr 2011 15:35:33 +0800
From:	Haojian Zhuang <haojian.zhuang@...il.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	zippel@...ux-m68k.org, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: LOCALVERSION in setlocalversion

On Tue, Apr 19, 2011 at 2:58 PM, Michal Marek <mmarek@...e.cz> wrote:
> On 19.4.2011 08:42, Haojian Zhuang wrote:
>> In scripts/setlocalversion under linux kernel tree, the scripts seems
>> a little strange.
> [...]
>>         # append a plus sign if the repository is not in a clean
>>         # annotated or signed tagged state (as git describe only
>>         # looks at signed or annotated tags - git tag -a/-s) and
>>         # LOCALVERSION= is not specified
>>         if test "${LOCALVERSION+set}" != "set"; then
>>                 scm=$(scm_version --short)
>>                 res="$res${scm:++}"
>>         fi
>> fi
>>
>> LOCALVERSION isn't assigned in any place. Only CONFIG_LOCALVERSION
>> can be assigned in .config file.
>> Why do we need to check LOCALVERSION at here?
>
> It can be set on the commandline:
>
> make LOCALVERSION=something
>
> Michal
>

Thanks a lot. It works.

I still have a question. I can't find the semantic of
${LOCALVERSION+set} in some
shell tutorials. Could you help me to figure out a link of introducing this?

Best Regards
Haojian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/