linux-kernel - Re: [PATCH 14/14] regulator: 88pm8607: avoid to use constraint name in driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Apr 2011 09:13:04 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Haojian Zhuang <hzhuang1@...vell.com>
Cc:	Haojian Zhuang <haojian.zhuang@...il.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
	"a.zummo@...ertech.it" <a.zummo@...ertech.it>,
	"johnpol@....mipt.ru" <johnpol@....mipt.ru>,
	"cbou@...l.ru" <cbou@...l.ru>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"lrg@...mlogic.co.uk" <lrg@...mlogic.co.uk>
Subject: Re: [PATCH 14/14] regulator: 88pm8607: avoid to use constraint name
 in driver

On Mon, Apr 18, 2011 at 07:45:06PM -0700, Haojian Zhuang wrote:

> >I assume that by "platform driver" you mean the machine driver for the
> >system?  What I'm saying is that instead of using a string to match it'd
> >be more normal to use an enum in the driver header, that way if someone
> >typos the string or something then there will be a build failure whereas
> >with strings like this there will only be a runtime failure.

> It's nearly same whatever it's string or index number. In machine driver,
> it's more convenient on using string. Otherwise, I still need to create

You're saying it's more convenient but you're not saying why.  I'd say
that the lack of build time checking I mentioned is actually unhelpful.

> a new integer array to store index since I transfer them into regulator data
> by driver_data parameter in regulator_init_data.

You already need to add a char * to store the name, adding an enum
instead isn't a substantial difference...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/