[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4DACEA40.5020008@cn.fujitsu.com>
Date: Tue, 19 Apr 2011 09:49:52 +0800
From: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To: Chris Mason <chris.mason@...cle.com>
CC: LKML <linux-kernel@...r.kernel.org>,
BTRFS <linux-btrfs@...r.kernel.org>
Subject: Re: [PATCH 1/2] Btrfs: allocate extent state and check the result
properly
On 04/12/2011 04:14 PM, Xiao Guangrong wrote:
> It doesn't allocate extent_state and check the result properly:
> - in set_extent_bit, it doesn't allocate extent_state if the path is not
> allowed wait
>
> - in clear_extent_bit, it doesn't check the result after atomic-ly allocate,
> we trigger BUG_ON() if it's fail
>
> - if allocate fail, we trigger BUG_ON instead of returning -ENOMEM since
> the return value of clear_extent_bit() is ignored by many callers
>
Ping...to see what happened. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists