linux-kernel - Re: [PATCH 2/2] drm: Verify debug message arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Apr 2011 09:31:43 -0700
From:	Joe Perches <joe@...ches.com>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	Ian Romanick <idr@...edesktop.org>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 2/2] drm: Verify debug message arguments

On Tue, 2011-04-19 at 18:26 +0200, Marcin Slusarz wrote:
> On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote:
> > On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:
> > > > -		DRM_DEBUG_KMS("LVDS downclock is found in VBT. ",
> > > > -				"Normal Clock %dKHz, downclock %dKHz\n",
> > > > -				temp_downclock, panel_fixed_mode->clock);
> > > > +		DRM_DEBUG_KMS("LVDS downclock is found in VBT. "
> > > > +			      "Normal Clock %dKHz, downclock %dKHz\n",
> > > > +			      temp_downclock, panel_fixed_mode->clock);
> > > Does this hunk only change white space, or am I missing something?
> > No, you're right.  It's just whitespace.
> > I prefer arguments aligned to open paren.
> It's not just whitespace. Look at the end of first line.

Heh.  Thanks Marcin.

Teach me to just at the code in the patch.

It's a format error as the first quoted string has
a comma at the end so the arguments after the comma
were ignored.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/